Skip to content

feature/34-implement-/roles-endpoint#94

Merged
MasterEvarior merged 21 commits into
mainfrom
feature/34-implement-/roles-endpoint
Sep 16, 2025
Merged

feature/34-implement-/roles-endpoint#94
MasterEvarior merged 21 commits into
mainfrom
feature/34-implement-/roles-endpoint

Conversation

@lcanobbio

Copy link
Copy Markdown
Collaborator

No description provided.

@lcanobbio lcanobbio linked an issue Sep 5, 2025 that may be closed by this pull request
7 tasks
@lcanobbio lcanobbio changed the title feat: add role entity class #34 feature/34-implement-/roles-endpoint Sep 5, 2025
@lcanobbio lcanobbio self-assigned this Sep 5, 2025
Comment thread backend/src/main/resources/db/migration/V0_0_2__role.sql Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/controller/RoleController.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/repository/RoleRepository.java
Comment thread backend/src/main/java/ch/puzzle/pcts/model/role/Role.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/service/business/RoleBusinessService.java Outdated
@nevio18324

nevio18324 commented Sep 10, 2025

Copy link
Copy Markdown
Collaborator

This ticket should be done the only things missing are
Integration tests for:

  • Controller
  • Services
  • Mapper

For the mapper tests i would take a look at #90 where a test for ExampleMapper was written

@lcanobbio lcanobbio force-pushed the feature/34-implement-/roles-endpoint branch 2 times, most recently from f108066 to 8966275 Compare September 12, 2025 13:16
@lcanobbio lcanobbio marked this pull request as ready for review September 12, 2025 13:43
Comment thread backend/src/main/resources/db/migration/V0_0_2__role.sql Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/service/business/RoleBusinessService.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/controller/RoleController.java Outdated
Comment thread backend/src/main/resources/db/migration/V0_0_2__role.sql
Comment thread backend/src/test/java/ch/puzzle/pcts/controller/RoleControllerIT.java Outdated
Comment thread backend/src/test/java/ch/puzzle/pcts/controller/RoleControllerIT.java Outdated
class RolePersistenceServiceIT {

@Container
static PostgreSQLContainer<?> postgres = new PostgreSQLContainer<>("postgres:17-alpine");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Is there a reason we use another postgres distro here than in the docker image we plan on go productive on? I reckon if we actually use Postgres as a testing DB we use the same image as for dev and prod, also i would reckon to add a properties var for that in order to prevent later maintenace hell. What do you reckon @MasterEvarior ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the same images is a great catch! Im not sure which one we use though, the docs only specifies version 16. Do you have any more details?

Regarding the property, would certainly be nice to have. If we have time, lets do it. In doubt CTRL-SHIFT-R, will do the same job and we get a ticket for the backlog.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havent checked the docs but probably its worth contacting the Sys-TV and ask specifically.. I just saw that the docker service used for dev uses a postgres.17 vanilla.. I am not sure what the cluster specifies but its worth asking.

For the properties var this can simply be set under any key you wish and referenced as @value("specified.key.you.wish") per test class. Maybe here it is even worth making an Abstract Base Integration test class where we can extend all Integration tests from which specifies the order and so on. I propose we discuss this tomorrow in person. May very well be that i already overcomplicate things. :D

@lcanobbio lcanobbio force-pushed the feature/34-implement-/roles-endpoint branch from 18d6b3a to e6da7c8 Compare September 15, 2025 13:16
@lcanobbio lcanobbio force-pushed the feature/34-implement-/roles-endpoint branch from add2089 to 5b2af87 Compare September 16, 2025 06:19
@MasterEvarior MasterEvarior merged commit 92bcf57 into main Sep 16, 2025
7 checks passed
@MasterEvarior MasterEvarior deleted the feature/34-implement-/roles-endpoint branch September 16, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Technical Story: Implement /roles endpoint

5 participants