feature/34-implement-/roles-endpoint#94
Conversation
|
This ticket should be done the only things missing are
For the mapper tests i would take a look at #90 where a test for ExampleMapper was written |
f108066 to
8966275
Compare
| class RolePersistenceServiceIT { | ||
|
|
||
| @Container | ||
| static PostgreSQLContainer<?> postgres = new PostgreSQLContainer<>("postgres:17-alpine"); |
There was a problem hiding this comment.
Nit: Is there a reason we use another postgres distro here than in the docker image we plan on go productive on? I reckon if we actually use Postgres as a testing DB we use the same image as for dev and prod, also i would reckon to add a properties var for that in order to prevent later maintenace hell. What do you reckon @MasterEvarior ?
There was a problem hiding this comment.
Using the same images is a great catch! Im not sure which one we use though, the docs only specifies version 16. Do you have any more details?
Regarding the property, would certainly be nice to have. If we have time, lets do it. In doubt CTRL-SHIFT-R, will do the same job and we get a ticket for the backlog.
There was a problem hiding this comment.
I havent checked the docs but probably its worth contacting the Sys-TV and ask specifically.. I just saw that the docker service used for dev uses a postgres.17 vanilla.. I am not sure what the cluster specifies but its worth asking.
For the properties var this can simply be set under any key you wish and referenced as @value("specified.key.you.wish") per test class. Maybe here it is even worth making an Abstract Base Integration test class where we can extend all Integration tests from which specifies the order and so on. I propose we discuss this tomorrow in person. May very well be that i already overcomplicate things. :D
18d6b3a to
e6da7c8
Compare
add2089 to
5b2af87
Compare
No description provided.